This repository was archived by the owner on Feb 23, 2018. It is now read-only.
Fill Exception message when maximum String literal length is exceeded #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
changed the title
Gatling compiles Scala classes on the fly with Zinc. Be it a program bug or a user error, some Strings sometimes end up being longer than the maximum String length. It would be nice if we could get an Exception with the proper message. I guess there's the same issue with maximum file size and maximum method size, will check.
|
@lrytz Gentle ping. Anyone in here? |
|
Hi, sorry about this delay.. In principle we try to keep the changes in this repo minimal compared to upstream ASM, but there are other changes we have that I should propose upstream, so another exception is fine. |
|
In order for this to get live we need to push a new release - this will happen anyway at some point, should we just wait for the next release? |
|
Thanks for merging! Should I do a similar PR against upstream ASM then? |
|
If you have time, sure! They're not on GitHub, I'm not exactly sure what's their workflow - maybe it's best to ask on the mailing list. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gatling compiles Scala classes on the fly with Zinc.
Be it a program bug or a user error, some Strings sometimes end up being longer than the maximum String length. It would be nice if we could get an Exception with the proper message.
I guess there's the same issue with maximum file size and maximum method size, will check.